Skip to content

cleanup VertexSoA/test/BuildFile to avoid duplicate dependencies #49292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2025
Merged

cleanup VertexSoA/test/BuildFile to avoid duplicate dependencies #49292

merged 1 commit into from
Nov 14, 2025
+4 −8

Conversation

@smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Nov 3, 2025

This fixes the SCRAM warnings

***WARNING: Multiple usage of "alpaka". Please cleanup "use" in "export" section of "src/DataFormats/VertexSoA/test/BuildFile.xml"
***WARNING: Multiple usage of "eigen". Please cleanup "use" in "export" section of "src/DataFormats/VertexSoA/test/BuildFile.xml"
***WARNING: Multiple usage of "alpaka". Please cleanup "use" in "export" section of "src/DataFormats/VertexSoA/test/BuildFile.xml"
***WARNING: Multiple usage of "eigen". Please cleanup "use" in "export" section of "src/DataFormats/VertexSoA/test/BuildFile.xml"
***WARNING: Multiple usage of "alpaka". Please cleanup "use" in "export" section of "src/DataFormats/VertexSoA/test/BuildFile.xml"
***WARNING: Multiple usage of "eigen". Please cleanup "use" in "export" section of "src/DataFormats/VertexSoA/test/BuildFile.xml"
***WARNING: Multiple usage of "alpaka". Please cleanup "use" in "export" section of "src/DataFormats/VertexSoA/test/BuildFile.xml"

@cmsbuild cmsbuild added this to the CMSSW_16_0_X milestone Nov 3, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2025 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49292/46650

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2025

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • DataFormats/VertexSoA (heterogeneous, reconstruction)

@cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Nov 3, 2025

FYI @AdrianoDee
Any idea why https://github.com/cms-sw/cmssw/pull/49200/files#diff-22f3c11b30be85f1c4e4fcc14af372618f9cac199d7fb61b04d086f7d757604dR1-R6 in global section of BuildFile were needed?

@AdrianoDee
Copy link
Contributor

AdrianoDee commented Nov 3, 2025

FYI @AdrianoDee Any idea why https://github.com/cms-sw/cmssw/pull/49200/files#diff-22f3c11b30be85f1c4e4fcc14af372618f9cac199d7fb61b04d086f7d757604dR1-R6 in global section of BuildFile were needed?

Just a dummy copy-paste on my side. Thanks for taking care of it.

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Nov 3, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2025

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c04d1/49206/summary.html
COMMIT: 4adf878
CMSSW: CMSSW_16_0_X_2025-11-02-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49292/49206/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3939953
  • DQMHistoTests: Total failures: 80
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3939853
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 3, 2025

+1

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Nov 11, 2025

@cms-sw/heterogeneous-l2 can you please review this? This is just a cleanup of BuildFile to avoid duplicates

fwyzard
fwyzard reviewed Nov 11, 2025
View reviewed changes
fwyzard
fwyzard reviewed Nov 11, 2025
View reviewed changes
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 11, 2025

Pull request #49292 was updated. @cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @srimanob can you please check and sign again.

@smuzaffar smuzaffar force-pushed the VertexSoA-test-duplicate-dep branch from 78c89fe to 3c8e9ae Compare November 11, 2025 21:40
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 11, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49292/46777

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 11, 2025

Pull request #49292 was updated. @cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @srimanob can you please check and sign again.

@fwyzard
Copy link
Contributor

fwyzard commented Nov 11, 2025

+heterogeneous

@fwyzard
Copy link
Contributor

fwyzard commented Nov 11, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 11, 2025

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c04d1/49413/summary.html
COMMIT: 3c8e9ae
CMSSW: CMSSW_16_0_X_2025-11-11-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49292/49413/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • Reco comparison had 2 failed jobs
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3939953
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3939924
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 14, 2025

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 14, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

mandrenguyen commented Nov 14, 2025

+1

@cmsbuild cmsbuild merged commit 8e2bf45 into cms-sw:master Nov 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fwyzard fwyzard fwyzard left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-checks-approved fully-signed heterogeneous-approved orp-approved reconstruction-approved tests-approved

Projects

None yet

Milestone

CMSSW_16_0_X

Development

Successfully merging this pull request may close these issues.

6 participants

@smuzaffar @cmsbuild @AdrianoDee @jfernan2 @fwyzard @mandrenguyen